Skip to content

SNS Prep work #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

SNS Prep work #1158

wants to merge 2 commits into from

Conversation

rogerhu
Copy link
Contributor

@rogerhu rogerhu commented Mar 23, 2016

Need to reuse APNS and GCM code.

@gfosco @flovilmart

@flovilmart
Copy link
Contributor

please rebase on master

Need to reuse APNS and GCM code.
@facebook-github-bot
Copy link

@rogerhu updated the pull request.

@codecov-io
Copy link

Current coverage is 91.27%

Merging #1158 into master will decrease coverage by -0.60% as of bf0805f

@@            master   #1158   diff @@
======================================
  Files           93      93       
  Stmts         5812    5814     +2
  Branches      1056    1058     +2
  Methods          0       0       
======================================
- Hit           5340    5307    -33
  Partial         11      11       
- Missed         461     496    +35

Review entire Coverage Diff as of bf0805f

Powered by Codecov. Updated on successful CI builds.

@facebook-github-bot
Copy link

@rogerhu updated the pull request.

@rogerhu
Copy link
Contributor Author

rogerhu commented Mar 24, 2016

I've prepped https://github.com/rogerhu/parse-server-sns-adapter

  1. My issue of course is being able to run tests without the use of submodule.
  2. The 2nd commit (04e2c48) is intended to allow importing these things directly. I would need to change the import paths (https://github.com/rogerhu/parse-server-sns-adapter/blob/master/src/SNSPushAdapter.js#L5-L14) to match though.

What is the best way to allow tests to run while also being able to publish?

@flovilmart
Copy link
Contributor

We're in the process of removing all adapters from parse-server, not sure if you shouldn't instead focus on a standalone package.

@flovilmart
Copy link
Contributor

I'll probably move the ParsePushAdapter to parse-server-push-adapter with all the needed dependencies. Stay tuned !

@rogerhu
Copy link
Contributor Author

rogerhu commented Mar 25, 2016

@rogerhu rogerhu closed this Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants