Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify authentication #1226

Merged
merged 1 commit into from
Apr 5, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/authDataManager/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ let meetup = require("./meetup");
let google = require("./google");
let github = require("./github");
let twitter = require("./twitter");
let spotify = require("./spotify");

let anonymous = {
validateAuthData: () => {
Expand All @@ -23,6 +24,7 @@ let providers = {
google,
github,
twitter,
spotify,
anonymous
}

Expand All @@ -33,14 +35,14 @@ module.exports = function(oauthOptions = {}, enableAnonymousUsers = true) {
}
// To handle the test cases on configuration
let getValidatorForProvider = function(provider) {

if (provider === 'anonymous' && !_enableAnonymousUsers) {
return;
}

let defaultProvider = providers[provider];
let optionalProvider = oauthOptions[provider];

if (!defaultProvider && !optionalProvider) {
return;
}
Expand All @@ -49,7 +51,7 @@ module.exports = function(oauthOptions = {}, enableAnonymousUsers = true) {
if (optionalProvider) {
appIds = optionalProvider.appIds;
}

var validateAuthData;
var validateAppId;

Expand All @@ -72,11 +74,11 @@ module.exports = function(oauthOptions = {}, enableAnonymousUsers = true) {
validateAppId = optionalProvider.validateAppId;
}
}

if (!validateAuthData || !validateAppId) {
return;
}

return function(authData) {
return validateAuthData(authData, optionalProvider).then(() => {
if (appIds) {
Expand All @@ -89,6 +91,6 @@ module.exports = function(oauthOptions = {}, enableAnonymousUsers = true) {

return Object.freeze({
getValidatorForProvider,
setEnableAnonymousUsers,
setEnableAnonymousUsers,
})
}
64 changes: 64 additions & 0 deletions src/authDataManager/spotify.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
// Helper functions for accessing the Spotify API.
var https = require('https');
var Parse = require('parse/node').Parse;

// Returns a promise that fulfills iff this user id is valid.
function validateAuthData(authData) {
return request('me', authData.access_token)
.then((data) => {
if (data && data.id == authData.id) {
return;
}
throw new Parse.Error(
Parse.Error.OBJECT_NOT_FOUND,
'Spotify auth is invalid for this user.');
});
}

// Returns a promise that fulfills if this app id is valid.
function validateAppId(appIds, authData) {
var access_token = authData.access_token;
if (!appIds.length) {
throw new Parse.Error(
Parse.Error.OBJECT_NOT_FOUND,
'Spotify auth is not configured.');
}
return request('me', access_token)
.then((data) => {
if (data && appIds.indexOf(data.id) != -1) {
return;
}
throw new Parse.Error(
Parse.Error.OBJECT_NOT_FOUND,
'Spotify auth is invalid for this user.');
});
}

// A promisey wrapper for Spotify API requests.
function request(path, access_token) {
return new Promise(function(resolve, reject) {
https.get({
host: 'api.spotify.com',
path: '/v1/' + path,
headers: {
'Authorization': 'Bearer '+access_token
}
}, function(res) {
var data = '';
res.on('data', function(chunk) {
data += chunk;
});
res.on('end', function() {
data = JSON.parse(data);
resolve(data);
});
}).on('error', function(e) {
reject('Failed to validate this access token with Spotify.');
});
});
}

module.exports = {
validateAppId: validateAppId,
validateAuthData: validateAuthData
};