Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports increment as well as Increment #1248

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Supports increment as well as Increment #1248

merged 1 commit into from
Mar 29, 2016

Conversation

flovilmart
Copy link
Contributor

fixes #1223

@flovilmart flovilmart force-pushed the flovilmart.incrementBadge branch from dbed76b to 4891afb Compare March 29, 2016 15:09
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart force-pushed the flovilmart.incrementBadge branch from 4891afb to 2bce760 Compare March 29, 2016 16:43
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@drew-gross
Copy link
Contributor

Test failures. Also, when doing something atypical such as accepting case insensitive input, can you make sure the code is well commented? Mention that it's for legacy reasons, etc.

@flovilmart flovilmart force-pushed the flovilmart.incrementBadge branch from 2bce760 to 6a98e70 Compare March 29, 2016 18:04
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart force-pushed the flovilmart.incrementBadge branch from 6a98e70 to cb4b036 Compare March 29, 2016 19:40
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@codecov-io
Copy link

Current coverage is 92.99%

Merging #1248 into master will not affect coverage as of 53f1131

@@            master   #1248   diff @@
======================================
  Files           84      84       
  Stmts         5265    5265       
  Branches       956     956       
  Methods          0       0       
======================================
  Hit           4896    4896       
  Partial         11      11       
  Missed         358     358

Review entire Coverage Diff as of 53f1131

Powered by Codecov. Updated on successful CI builds.

@drew-gross drew-gross merged commit 337d3c2 into master Mar 29, 2016
@drew-gross drew-gross deleted the flovilmart.incrementBadge branch March 29, 2016 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@drew-gross drew-gross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push notification - bage increment - changed to uppercase "I"?
4 participants
@flovilmart @facebook-github-bot @drew-gross @codecov-io