Single object queries to use include and keys #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
This code looks good, but would you mind added a test case for it? In |
|
Yeah, I will ASAP. |
|
Added the test cases. |
| return rest.find(req.config, req.auth, req.params.className, {objectId: req.params.objectId}) | ||
| let body = Object.assign(req.body, ClassesRouter.JSONFromQuery(req.query)); | ||
| let options = {}; | ||
| let allowConstraints = ['keys', 'include']; |
There was a problem hiding this comment.
can we move that up as a const ALLOWED_GET_QUERY_KEYS
|
@jeremyjackson89 updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@jeremyjackson89 updated the pull request. |
|
@drew-gross @flovilmart when will this be released to the npm package? Thanks |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow queries on specific objects to use the include and keys query parameters.