-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to override mount with publicServerURL for production uses #1287
Conversation
34051bd
to
ab18586
Compare
Current coverage is
|
I think we actually don't want to do this, since we don't really want internal queries to go back out to the public internet to do dns resolution and so on. |
We only use .mount to give back to the clients (and in file adapters) |
It's the only occurrence besides GridStoreAdapter and all FilesAdapter which both need public URL's otherwise create files that are referenced by the requested host i.e.: localhost:1337 And Do you see other cases? |
Ah right this is only for the mount point, not the URL. In that case this looks good. |
This is the full URL that is returned to the clients, mount is currently inferred :
|
superseds #1270
fixes #1131
also adds a sanity so we don't keep trailing / in mount or publicServerURL