-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1271 #1295
Merged
+102
−74
Merged
Fixes #1271 #1295
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Improve comments
- moumouls-5.0.0-alpha.20
- moumouls-5.0.0-alpha.20-h1
- force-tag
- beta.27
- beta.26
- beta.25
- beta.24
- beta.23
- beta.22
- beta.20
- beta.19
- beta.18
- beta.17
- beta.16.1
- beta.16
- beta.15
- beta.15.test2
- beta.14
- beta.13
- beta.12
- beta.11
- beta.10
- beta.9
- beta.8
- beta.7
- beta.6
- beta.5
- beta.4
- beta.3
- beta.2
- 7.4.0-alpha.7
- 7.4.0-alpha.6
- 7.4.0-alpha.5
- 7.4.0-alpha.4
- 7.4.0-alpha.3
- 7.4.0-alpha.2
- 7.4.0-alpha.1
- 7.3.1-alpha.1
- 7.3.0
- 7.3.0-beta.1
- 7.3.0-alpha.9
- 7.3.0-alpha.8
- 7.3.0-alpha.7
- 7.3.0-alpha.6
- 7.3.0-alpha.5
- 7.3.0-alpha.4
- 7.3.0-alpha.3
- 7.3.0-alpha.2
- 7.3.0-alpha.1
- 7.2.0
- 7.2.0-beta.1
- 7.1.0
- 7.1.0-beta.1
- 7.1.0-alpha.16
- 7.1.0-alpha.15
- 7.1.0-alpha.14
- 7.1.0-alpha.13
- 7.1.0-alpha.12
- 7.1.0-alpha.11
- 7.1.0-alpha.10
- 7.1.0-alpha.9
- 7.1.0-alpha.8
- 7.1.0-alpha.7
- 7.1.0-alpha.6
- 7.1.0-alpha.5
- 7.1.0-alpha.4
- 7.1.0-alpha.3
- 7.1.0-alpha.2
- 7.1.0-alpha.1
- 7.0.0
- 7.0.0-beta.1
- 7.0.0-alpha.31
- 7.0.0-alpha.30
- 7.0.0-alpha.29
- 7.0.0-alpha.28
- 7.0.0-alpha.27
- 7.0.0-alpha.26
- 7.0.0-alpha.25
- 7.0.0-alpha.24
- 7.0.0-alpha.23
- 7.0.0-alpha.22
- 7.0.0-alpha.21
- 7.0.0-alpha.20
- 7.0.0-alpha.19
- 7.0.0-alpha.18
- 7.0.0-alpha.17
- 7.0.0-alpha.16
- 7.0.0-alpha.15
- 7.0.0-alpha.14
- 7.0.0-alpha.13
- 7.0.0-alpha.12
- 7.0.0-alpha.11
- 7.0.0-alpha.10
- 7.0.0-alpha.9
- 7.0.0-alpha.8
- 7.0.0-alpha.7
- 7.0.0-alpha.6
- 7.0.0-alpha.5
- 7.0.0-alpha.4
- 7.0.0-alpha.3
- 7.0.0-alpha.2
- 7.0.0-alpha.1
- 6.5.11
- 6.5.10
- 6.5.9
- 6.5.8
- 6.5.7
- 6.5.6
- 6.5.5
- 6.5.4
- 6.5.3
- 6.5.2
- 6.5.1
- 6.5.0
- 6.5.0-beta.1
- 6.5.0-alpha.2
- 6.5.0-alpha.1
- 6.4.0
- 6.4.0-beta.1
- 6.4.0-alpha.8
- 6.4.0-alpha.7
- 6.4.0-alpha.7.moumouls.2
- 6.4.0-alpha.7.moumouls.1
- 6.4.0-alpha.6
- 6.4.0-alpha.5
- 6.4.0-alpha.4
- 6.4.0-alpha.3
- 6.4.0-alpha.2
- 6.4.0-alpha.1
- 6.3.1
- 6.3.0
- 6.3.0-beta.1
- 6.3.0-alpha.9
- 6.3.0-alpha.8
- 6.3.0-alpha.7
- 6.3.0-alpha.7.moumouls.5
- 6.3.0-alpha.7.moumouls.4
- 6.3.0-alpha.7.moumouls.3
- 6.3.0-alpha.7.moumouls.2
- 6.3.0-alpha.7.moumouls.1
- 6.3.0-alpha.7.moumouls.apollo.7
- 6.3.0-alpha.7.moumouls.apollo.6
- 6.3.0-alpha.7.moumouls.apollo.5
- 6.3.0-alpha.6
- 6.3.0-alpha.5
- 6.3.0-alpha.4.1.moumouls
- 6.3.0-alpha.4
- 6.3.0-alpha.4.moumouls
- 6.3.0-alpha.3
- 6.3.0-alpha.2
- 6.3.0-alpha.1
- 6.2.2
- 6.2.1
- 6.2.0
- 6.1.0
- 6.1.0-beta.2
- 6.1.0-beta.1
- 6.1.0-alpha.20
- 6.1.0-alpha.19
- 6.1.0-alpha.18
- 6.1.0-alpha.17
- 6.1.0-alpha.16
- 6.1.0-alpha.15
- 6.1.0-alpha.14
- 6.1.0-alpha.13
- 6.1.0-alpha.12
- 6.1.0-alpha.11
- 6.1.0-alpha.10
- 6.1.0-alpha.9
- 6.1.0-alpha.8
- 6.1.0-alpha.7.6.moumouls
- 6.1.0-alpha.7.5.moumouls
- 6.1.0-alpha.7.4.moumouls
- 6.1.0-alpha.7.3.moumouls
- 6.1.0-alpha.7.2.moumouls
- 6.1.0-alpha.7
- 6.1.0-alpha.7.moumouls
- 6.1.0-alpha.6
- 6.1.0-alpha.5
- 6.1.0-alpha.4
- 6.1.0-alpha.3
- 6.1.0-alpha.2
- 6.1.0-alpha.1
- 6.0.0
- 6.0.0-beta.1
- 6.0.0-alpha.35
- 6.0.0-alpha.34
- 6.0.0-alpha.33
- 6.0.0-alpha.32
- 6.0.0-alpha.31
- 6.0.0-alpha.30
- 6.0.0-alpha.29
- 6.0.0-alpha.28
- 6.0.0-alpha.27
- 6.0.0-alpha.26
- 6.0.0-alpha.25
- 6.0.0-alpha.24
- 6.0.0-alpha.23
- 6.0.0-alpha.22
- 6.0.0-alpha.21
- 6.0.0-alpha.20
- 6.0.0-alpha.19
- 6.0.0-alpha.18
- 6.0.0-alpha.17
- 6.0.0-alpha.16
- 6.0.0-alpha.15
- 6.0.0-alpha.14
- 6.0.0-alpha.13
- 6.0.0-alpha.12
- 6.0.0-alpha.11
- 6.0.0-alpha.10
- 6.0.0-alpha.9
- 6.0.0-alpha.8
- 6.0.0-alpha.7
- 6.0.0-alpha.6
- 6.0.0-alpha.5
- 6.0.0-alpha.4
- 6.0.0-alpha.3
- 6.0.0-alpha.2
- 6.0.0-alpha.1
- 5.6.0
- 5.5.6
- 5.5.5
- 5.5.4
- 5.5.3
- 5.5.2
- 5.5.1
- 5.5.0
- 5.4.3
- 5.4.2
- 5.4.1
- 5.4.0
- 5.4.0-beta.1
- 5.4.0-alpha.1
- 5.3.3
- 5.3.2
- 5.3.1
- 5.3.0
- 5.3.0-beta.1
- 5.3.0-alpha.32
- 5.3.0-alpha.31
- 5.3.0-alpha.30
- 5.3.0-alpha.29
- 5.3.0-alpha.29.test-final-auth1
- 5.3.0-alpha.28
- 5.3.0-alpha.27
- 5.3.0-alpha.26
- 5.3.0-alpha.25
- 5.3.0-alpha.24
- 5.3.0-alpha.23
- 5.3.0-alpha.22
- 5.3.0-alpha.21
- 5.3.0-alpha.20
- 5.3.0-alpha.19
- 5.3.0-alpha.18
- 5.3.0-alpha.17
- 5.3.0-alpha.16.16.moumouls
- 5.3.0-alpha.16.15.moumouls
- 5.3.0-alpha.16.14.moumouls
- 5.3.0-alpha.16.13.moumouls
- 5.3.0-alpha.16.12.moumouls
- 5.3.0-alpha.16.11.moumouls
- 5.3.0-alpha.16.10.moumouls
- 5.3.0-alpha.16.9.moumouls
- 5.3.0-alpha.16.8.moumouls
- 5.3.0-alpha.16.7.moumouls
- 5.3.0-alpha.16.6.moumouls
- 5.3.0-alpha.16.5.moumouls
- 5.3.0-alpha.16.4.moumouls
- 5.3.0-alpha.16.3.moumouls
- 5.3.0-alpha.16.2.moumouls
- 5.3.0-alpha.16.1.moumouls
- 5.3.0-alpha.16
- 5.3.0-alpha.16.moumouls
- 5.3.0-alpha.15
- 5.3.0-alpha.14
- 5.3.0-alpha.13
- 5.3.0-alpha.12
- 5.3.0-alpha.11
- 5.3.0-alpha.10
- 5.3.0-alpha.9
- 5.3.0-alpha.8
- 5.3.0-alpha.7
- 5.3.0-alpha.6
- 5.3.0-alpha.5
- 5.3.0-alpha.4
- 5.3.0-alpha.3
- 5.3.0-alpha.2
- 5.3.0-alpha.1
- 5.2.8
- 5.2.7
- 5.2.6
- 5.2.5
- 5.2.4
- 5.2.3
- 5.2.2
- 5.2.1
- 5.2.1-alpha.2
- 5.2.1-alpha.1
- 5.2.0
- 5.2.0-beta.2
- 5.2.0-beta.1
- 5.2.0-alpha.3
- 5.2.0-alpha.2
- 5.2.0-alpha.1
- 5.1.1
- 5.1.0
- 5.0.0
- 5.0.0-beta.10
- 5.0.0-beta.9
- 5.0.0-beta.8
- 5.0.0-beta.7
- 5.0.0-beta.6
- 5.0.0-beta.5
- 5.0.0-beta.4
- 5.0.0-beta.3
- 5.0.0-beta.2
- 5.0.0-beta.1
- 5.0.0-alpha.29
- 5.0.0-alpha.28
- 5.0.0-alpha.27
- 5.0.0-alpha.26
- 5.0.0-alpha.25
- 5.0.0-alpha.25.moumouls-collation
- 5.0.0-alpha.24
- 5.0.0-alpha.24.moumouls-collation
- 5.0.0-alpha.23
- 5.0.0-alpha.23.moumouls-collation
- 5.0.0-alpha.22
- 5.0.0-alpha.22.moumouls-collation
- 5.0.0-alpha.22.moumouls
- 5.0.0-alpha.21
- 5.0.0-alpha.21.moumouls
- 5.0.0-alpha.20
- 5.0.0-alpha.19
- 5.0.0-alpha.18
- 5.0.0-alpha.17
- 5.0.0-alpha.16
- 5.0.0-alpha.15
- 5.0.0-alpha.14
- 5.0.0-alpha.13
- 5.0.0-alpha.12
- 5.0.0-alpha.11
- 5.0.0-alpha.10
- 5.0.0-alpha.9
- 5.0.0-alpha.8
- 5.0.0-alpha.7
- 5.0.0-alpha.6
- 5.0.0-alpha.5
- 5.0.0-alpha.4
- 5.0.0-alpha.3
- 5.0.0-alpha.2
- 5.0.0-alpha.1
- 4.10.20
- 4.10.19
- 4.10.18
- 4.10.17
- 4.10.16
- 4.10.15
- 4.10.14
- 4.10.13
- 4.10.12
- 4.10.11
- 4.10.10
- 4.10.9
- 4.10.8
- 4.10.7
- 4.10.6
- 4.10.5
- 4.10.4
- 4.10.3
- 4.10.2
- 4.10.1
- 4.10.0
- 4.9.3
- 4.9.2
- 4.9.1
- 4.9.0
- 4.8.5
- 4.8.4
- 4.8.3
- 4.8.2
- 4.8.1
- 4.8.0
- 4.7.0
- 4.6.0
- 4.6.0-beta
- 4.5.2
- 4.5.0
- 4.4.0
- 4.3.0
- 4.2.0
- 4.1.0
- 4.0.14
- 4.0.13
- 4.0.12
- 4.0.11
- 4.0.10
- 4.0.9
- 4.0.8
- 4.0.7
- 4.0.6
- 4.0.4
- 4.0.3
- 4.0.2
- 4.0.1
- 4.0.0
- 4.0.0-beta6
- 4.0.0-beta5
- 4.0.0-beta4
- 4.0.0-beta3
- 4.0.0-beta2
- 4.0.0-beta1
- 3.10.0
- 3.9.0
- 3.8.0
- 3.7.2
- 3.7.1
- 3.7.0
- 3.6.0
- 3.5.0
- 3.4.4
- 3.4.3
- 3.4.2
- 3.4.1
- 3.4.0
- 3.3.0
- 3.2.3
- 3.2.2
- 3.2.1
- 3.2.0
- 3.1.3
- 3.1.2
- 3.1.1
- 3.1.0
- 3.0.0
- 2.8.4
- 2.8.3
- 2.8.2
- 2.8.1
- 2.8.0
- 2.7.4
- 2.7.3
- 2.7.2
- 2.7.1
- 2.7.0
- 2.6.5
- 2.6.4
- 2.6.3
- 2.6.2
- 2.6.1
- 2.6.0
- 2.5.3
- 2.5.2
- 2.5.1
- 2.5.0
- 2.4.2
- 2.4.1
- 2.4.0
- 2.3.8
- 2.3.7
- 2.3.6
- 2.3.5
- 2.3.4
- 2.3.3
- 2.3.2
- 2.3.1
- 2.3.0
- 2.3.0-alpha1
- 2.2.25
- 2.2.25-beta.1
- 2.2.24
- 2.2.23
- 2.2.22
- 2.2.21
- 2.2.20
- 2.2.19
- 2.2.18
- 2.2.17
- 2.2.16
- 2.2.15
- 2.2.14
- 2.2.13
- 2.2.12
- 2.2.11
- 2.2.10
- 2.2.9
- 2.2.8
- 2.2.7
- 2.2.6
- 2.2.5
commit 73bca3b64ca082cb970ff2dfc9d2e50a5e6c8810
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -504,7 +504,9 @@ DatabaseController.prototype.addInObjectIdsIds = function(ids = null, query) { | |
idsIntersection = intersect(allIds); | ||
} | ||
|
||
// Need to make sure we don't clobber existing $lt or other constraints on objectId | ||
// Need to make sure we don't clobber existing $lt or other constraints on objectId. | ||
// Clobbering $eq, $in and shorthand $eq (query.objectId === 'string') constraints | ||
// is expected though. | ||
if (!('objectId' in query) || typeof query.objectId === 'string') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we move that up? be tough to follow why it's correct to override when |
||
query.objectId = {}; | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drew-gross @flovilmart
I ran into an issue migrating an app to Parse Server and I'm hoping you can shed some light on this. You can see the failing test I wrote here. On api.parse.com and Parse Server <= 2.2.4 this test passes.
I tracked the problem down to this comment. Should we really be clobbering $eq constraints here or should the test linked above pass? The hacky feeling workaround would be to replace
query.equalTo("objectId", cake1.id)
withquery.containedIn("objectId", [cake1.id])
in my test.Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeremyPlease I believe the test should pass as the query construction seem to be valid. Do you have an idea for the fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flovilmart Check out #2472 and let me know what you think.