Skip to content

Defers the session creation after DB operation #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2016
Merged

Defers the session creation after DB operation #1561

merged 1 commit into from
Apr 20, 2016

Conversation

flovilmart
Copy link
Contributor

Wait after the _User is created for creating the session token so we don't create extraneous ones.

fixes #1497

@codecov-io
Copy link

Current coverage is 92.79%

Merging #1561 into master will increase coverage by +0.02% as of b67a35b

@@            master   #1561   diff @@
======================================
  Files           87      87       
  Stmts         5484    5483     -1
  Branches      1019    1019       
  Methods          0       0       
======================================
  Hit           5088    5088       
  Partial          9       9       
+ Missed         387     386     -1

Review entire Coverage Diff as of b67a35b

Powered by Codecov. Updated on successful CI builds.

@flovilmart flovilmart merged commit 59b4047 into master Apr 20, 2016
@flovilmart flovilmart deleted the defer-session-token-creation branch April 20, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session token is generated even if user and session table is locked down via CLP.
4 participants
@flovilmart @codecov-io @drew-gross @facebook-github-bot