Skip to content

[WIP] we don't need to destroy all data both before starting a test AND after finishing it #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

drew-gross
Copy link
Contributor

This prevents the "error in clearData" log as well.

Still some failing tests.

@TylerBrock
Copy link
Contributor

TylerBrock commented May 18, 2016

Ah, i noticed this yesterday as well. Nice.

I'm seeing some of the same test failures when i try to run tests under linux. If we can figure this out it would be great.

@drew-gross
Copy link
Contributor Author

I think the _PushStatus collection is not getting deleted. Not 100% sure though. destroyAllDataPermanently goes through a bit of a sketchy code path that inspects mongo collection names, so it might be some issue there.

@drew-gross drew-gross closed this May 31, 2016
@drew-gross drew-gross deleted the fix-test-logs branch May 31, 2016 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants