Move query logic into mongo #1885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drew-gross
commented
May 23, 2016
drew-gross
commented
- Move some query related logic that uses mongo format into the mongo adapter.
- Move some Parse Server related logic out of MongoTransform and into Parse Server
- Fix a bunch of bugs involving untransforming Parse Objects by splitting untransformation of nested objects into it's own function.
…ame name as key in specific circumstances
ghost
added
the
Current coverage is 91.79%
@@ master #1885 diff @@
==========================================
Files 91 91
Lines 6376 6395 +19
Methods 1102 1105 +3
Messages 0 0
Branches 1332 1343 +11
==========================================
+ Hits 5866 5870 +4
- Misses 510 525 +15
Partials 0 0
|
|
LGTM. |
JeremyPlease
pushed a commit
to JeremyPlease/parse-server
that referenced
this pull request
May 24, 2016
* Move Parse Server logic into Parse Server and out of MongoAdapter * Move untransforming up one level * Make find() in MongoStorageAdapter * Put nested object untransforming into it's own function * Simplfy nested untransform * Don't mess with inner object keys called _auth_data_* * Prevent untransforming inner object keys named _p_* * Fix inner keys named _rperm, _wperm * Fix bugs with inner objects behaving strange when other fields have same name as key in specific circumstances * remove params from untransform nested object * Revert changes to find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.