Finish moving query logic #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| // Parse.com treats queries on _created_at and _updated_at as if they were queries on createdAt and updatedAt, | ||
| // so duplicate that behaviour here. If both are specified, the corrent behaviour to match Parse.com is to | ||
| // use the one that appears first in the sort list. | ||
| if (sort && sort._created_at) { |
There was a problem hiding this comment.
do we need the undefined check for sort since you've specified the default value?
There was a problem hiding this comment.
Probably not. Will change.
There was a problem hiding this comment.
Yep it was unnecessary, tests passed without.
|
@drew-gross updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatabaseController.prototype.find no longer depends on the mongo format, I think. Except maybe in count results.