Fix for #1840, Strip operations from results, forwards delete operations to SDKs #1946
Conversation
ghost
added
the
Current coverage is 91.87%
|
|
After further investigation, the Parse.com behaves the same way which is troubling... |
|
@flovilmart updated the pull request. |
|
Will be fixed by: parse-community/Parse-SDK-JS#289 |
|
This won't work as is, as the Client SDK's don't handle (at all the Delete operations when coming back from the server...) |
|
Waiting for the JS-SDK that implement the change to be released. |
|
We might be able to test this functionality with 1.9.0-rc1 now. |
|
I don't see it yet |
|
@flovilmart updated the pull request. |
|
@flovilmart updated the pull request. |
flovilmart
changed the title
|
@flovilmart updated the pull request. |
|
Something in here is causing the tests to consistently fail in postgres. Not sure what, excluding progres is probably fine though. |
|
@flovilmart updated the pull request. |
|
@drew-gross we may want to add a check on the client SDK version for the support of that feature no? |
|
@flovilmart updated the pull request. |
flovilmart
changed the title
- That test fails on parse.com as well
- Mark js1.9.0 as compatible
flovilmart
changed the title
- fix for #1606
flovilmart
changed the title
… delete operations to SDKs (parse-community#1946) * Adding a test demonstrating issue parse-community#1840. * Fixes parse-community#1840 * Adds failing test with other use case - That test fails on parse.com as well * Bumps parse to 1.9.0 * exclude pg db * Exclude pg on other test * Adds clientSDK compatibility check for forward deletion - Mark js1.9.0 as compatible * Strips all operations from result - fix for parse-community#1606
… delete operations to SDKs (parse-community#1946) * Adding a test demonstrating issue parse-community#1840. * Fixes parse-community#1840 * Adds failing test with other use case - That test fails on parse.com as well * Bumps parse to 1.9.0 * exclude pg db * Exclude pg on other test * Adds clientSDK compatibility check for forward deletion - Mark js1.9.0 as compatible * Strips all operations from result - fix for parse-community#1606
After a DB operation that was mutated by a beforeSave we'd loop through the new keys in order to set the DB computed values or the original value.
We strip all operations from the results, as the clients can't interpret it.
For compatible SDK's we reinject the delete ops so the client can safely remove the associated key without fetching again.
Fixes #1840
Closes #1940
Fixes #1606