Fixes for Class Level and Pointer Permissions #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug that would leave public CLP when setting a new set of permissions - Sets empty permissions if missing to match parse.com API - Updates tests to reflect changes
ghost
added
the
Current coverage is 91.91%
@@ master #1989 diff @@
==========================================
Files 91 91
Lines 6411 6418 +7
Methods 1095 1096 +1
Messages 0 0
Branches 1345 1346 +1
==========================================
+ Hits 5894 5899 +5
- Misses 517 519 +2
Partials 0 0
|
|
@flovilmart updated the pull request. |
| @@ -1573,4 +1569,40 @@ describe('schemas', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| fit("regression test for #1991", done => { | |||
There was a problem hiding this comment.
Should be it. Travis seems to have run every test anyway, though, so I will just merge and then fix this.
|
@flovilmart updated the pull request. |
This was referenced Jun 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1953