Disable tests that don't work in Postgres, and don't start a mongo for postgres tests #2481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@drew-gross updated the pull request. |
|
Opted to make the PR into master. Hopefully postgres tests don't continue to be a pain, it would be nice to prevent postgres regressions in master if possible. |
Current coverage is 92.00% (diff: 100%)@@ master #2481 diff @@
==========================================
Files 95 95
Lines 10706 10776 +70
Methods 1312 1332 +20
Messages 0 0
Branches 1738 1762 +24
==========================================
+ Hits 9837 9914 +77
+ Misses 869 862 -7
Partials 0 0
|
|
Let's see how it goes, once Travis finishes. |
|
Looks like both postgreses are passing. Just waiting on mongo now. Being able to not start mongo when running postgres tests should help somewhat. |
|
looks good! Merging! |
|
🎉 This change has been released in version 6.1.0-alpha.13 |
|
🎉 This change has been released in version 6.3.0-beta.1 |
|
🎉 This change has been released in version 6.3.0-alpha.1 |
|
🎉 This change has been released in version 6.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.