Implementing GET /config and POST /config support #283

theill · 2016-02-07T00:22:23Z

Adds support for retrieving global configuration by handling GET requests for /config. This will return a JSON payload with an params attribute with config.

Furthermore support for doing a POST to /config for updating this value.

drew-gross · 2016-02-07T01:46:37Z

Schema.js

@@ -75,6 +78,7 @@ function classNameIsValid(className) {
    className === '_Session' ||
    className === '_SCHEMA' || //TODO: remove this, as _SCHEMA is not a valid class name for storing Parse Objects.
    className === '_Role' ||
+    className === '_GlobalConfig' ||


This shouldn't really go here, as this is the place for the names of classes that the client is allowed to create. _SCHEMA is only here for legacy reasons, it should be removed.

Hmm, but as I see it it's used by ExportAdapter (see https://github.com/theill/parse-server/blob/master/ExportAdapter.js#L63) to filter what collections you're able to query. Is it because I'm going through wrong path?

ExportAdapter is the legacy user of this class that needs to be fixed before we can remove _SCHEMA from the list of valid class names. Take a look at schemas.js for how do it without using the classNameIsValid function.

Thanks, I'll take a look. It seems to be schemas.js uses req.config.database.collection to access a collection which eventually ends up with classNameIsValid too but I'll dig a bit deeper tonight.

Looks like you are right. Maybe we need a database.rawCollection() function or something like that, to bypass the classNameIsValid check.

That will work but then we need one for update too because the current update also uses database.collection

Or I can just do rawCollection().findAndModify() on it if that's ok. I'll update my PR with that and wait for your comments.

facebook-github-bot · 2016-02-07T12:52:12Z

@theill updated the pull request.

drew-gross · 2016-02-08T04:53:37Z

spec/ParseGlobalConfig.spec.js

@@ -0,0 +1,49 @@
+// run test when changing related file using
+// $ TESTING=1 node_modules/jasmine/bin/jasmine.js spec/ParseGlobalConfig.spec.js


I think one of our team members is in the middle of making some changes to our testing framework, so this comment is probably going to become out of date soon. Can you remove it? We'll keep instructions for how to run tests in CONTRIBUTING.md.

Sure, submitted patch 7733ab9

facebook-github-bot · 2016-02-08T08:06:10Z

@theill updated the pull request.

Updated tests accordingly to changed access

facebook-github-bot · 2016-02-08T23:37:11Z

@theill updated the pull request.

facebook-github-bot · 2016-02-08T23:43:21Z

@theill updated the pull request.

drew-gross · 2016-02-09T02:17:23Z

Schema.js

@@ -60,6 +60,9 @@ defaultColumns = {
    "expiresAt":      {type:'Date'},
    "createdWith":    {type:'Object'},
  },
+  _GlobalConfig: {


This defaultColumns object only tracks default columns for collections that contain Parse Objects (thats what _SCHEMA isn't in here. So I think config probably shouldn't be here either.

drew-gross · 2016-02-09T02:45:01Z

Looking awesome! As soon as this is hidden behind the experimental flag, I can land this. We just don't want to get into a situation where we are shipping a new version on npm that includes in-progress features, like we accidentally did for schemas API :) Thanks for the great work!

facebook-github-bot · 2016-02-09T10:11:11Z

@theill updated the pull request.

facebook-github-bot · 2016-02-09T10:29:11Z

@theill updated the pull request.

facebook-github-bot · 2016-02-09T11:34:16Z

@theill updated the pull request.

facebook-github-bot · 2016-02-11T00:14:10Z

@theill updated the pull request.

facebook-github-bot · 2016-02-11T00:34:19Z

@theill updated the pull request.

Implementing GET /config and POST /config support

douineauromain · 2016-02-16T11:06:04Z

Hello

So /1/config is now available ?
If now I install parse-server from npm will I have /1/config ?

If yes I think you should update https://parse.com/docs/server/guide#migrating

Thanks

drew-gross · 2016-02-16T22:54:41Z

Config is still experimental. We are doing further testing and will update the docs once we are confident in the implementation and its compatibility with Parse.com.

sghamaty · 2016-02-16T23:29:03Z

Anyone know if this Parse Config addition is included in the 2.0.8 parse-server npm? If not, any ideas when it might get packaged up?

I just pushed 2.0.8 to the Heroku server and still got "Cannot GET /1/config"

Thanks

gfosco · 2016-02-16T23:40:58Z

@sghamaty Did you change PARSE_MOUNT=/1 ? If not, the proper path is /parse/config by default.

sghamaty · 2016-02-16T23:56:29Z

Yes, my PARSE_MOUNT=/1 . Still not working.

On Tue, Feb 16, 2016 at 3:41 PM, Fosco Marotto notifications@github.com
wrote:

@sghamaty https://github.com/sghamaty Did you change PARSE_MOUNT=/1 ?
If not, the proper path is /parse/config by default.

—
Reply to this email directly or view it on GitHub
#283 (comment)
.

drew-gross · 2016-02-17T00:50:08Z

You also need to set PARSE_EXPERIMENTAL_CONFIG_ENABLED=1 environment variable.

sghamaty · 2016-02-17T19:48:40Z

Yes, that did it. Thanks

You also need to set PARSE_EXPERIMENTAL_CONFIG_ENABLED=1 environment variable.

douineauromain · 2016-02-26T10:59:52Z

Is it possible to do something like
var api = new ParseServer({ databaseURI: 'mongodb://localhost:27017/dev', [...] parseExperimentalConfigEnabled: true });
?

gfosco · 2016-02-26T11:06:55Z

@douineauromain It's not, but a PR that added this in src/index.js would be welcomed.

theill added 5 commits February 7, 2016 00:13

Add file for handling GET/POST to /config

3b4515a

Add route for handling /config

0dfb4ac

Open _GlobalConfig for querying

ba1104f

Add default column for _GlobalConfig

c8792b4

Add read/write test for _GlobalConfig

6fe050b

theill mentioned this pull request Feb 7, 2016

Support for Config #34

Closed

facebook-github-bot added the GH Review: review-needed label Feb 7, 2016

drew-gross reviewed Feb 7, 2016
View reviewed changes

drew-gross added GH Review: needs-revision and removed GH Review: review-needed labels Feb 7, 2016

Require masterKey when performing config updates

3b0ab80

facebook-github-bot added GH Review: review-needed and removed GH Review: needs-revision labels Feb 7, 2016

drew-gross reviewed Feb 8, 2016
View reviewed changes

Remove unnecessary comment about testing

7733ab9

Uses rawCollection() for direct db access

8b3f875

Updated tests accordingly to changed access

Revert commented out line

307a5d8

drew-gross reviewed Feb 9, 2016
View reviewed changes

theill added 3 commits February 9, 2016 10:23

Merged with master

7fa4b3b

Merge remote-tracking branch 'github/master'

f5b2821

Move global_config to new src/ location

11082b1

Update error message

bd4546f

Fixed reference after source move

84b35ea

Add test for uncovered cases

f039b70

theill added 4 commits February 11, 2016 00:44

Merge remote-tracking branch 'github/master'

ba68a79

Hide /config behind PARSE_EXPERIMENTAL_CONFIG_ENABLED flag

fb6af2c

Rearrange methods to follow route setup

1977769

Update PUT response to align with current dashboard

930573b

Update tests and ensure tests are run regardless of exp flag

1d576bc

drew-gross added a commit that referenced this pull request Feb 11, 2016

Merge pull request #283 from theill/master

5fb015e

Implementing GET /config and POST /config support

drew-gross merged commit 5fb015e into parse-community:master Feb 11, 2016

ndnguru mentioned this pull request Feb 17, 2016

What happens to AppConfig? #455

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing GET /config and POST /config support #283

Implementing GET /config and POST /config support #283

theill commented Feb 7, 2016

drew-gross Feb 7, 2016

theill Feb 7, 2016

drew-gross Feb 8, 2016

theill Feb 8, 2016

drew-gross Feb 8, 2016

theill Feb 8, 2016

theill Feb 8, 2016

facebook-github-bot commented Feb 7, 2016

drew-gross Feb 8, 2016

theill Feb 8, 2016

facebook-github-bot commented Feb 8, 2016

facebook-github-bot commented Feb 8, 2016

facebook-github-bot commented Feb 8, 2016

drew-gross Feb 9, 2016

drew-gross commented Feb 9, 2016

facebook-github-bot commented Feb 9, 2016

facebook-github-bot commented Feb 9, 2016

facebook-github-bot commented Feb 9, 2016

facebook-github-bot commented Feb 11, 2016

facebook-github-bot commented Feb 11, 2016

douineauromain commented Feb 16, 2016

drew-gross commented Feb 16, 2016

sghamaty commented Feb 16, 2016

gfosco commented Feb 16, 2016

sghamaty commented Feb 16, 2016

drew-gross commented Feb 17, 2016

sghamaty commented Feb 17, 2016

douineauromain commented Feb 26, 2016

gfosco commented Feb 26, 2016

		@@ -0,0 +1,49 @@
		// run test when changing related file using
		// $ TESTING=1 node_modules/jasmine/bin/jasmine.js spec/ParseGlobalConfig.spec.js

Implementing GET /config and POST /config support #283

Implementing GET /config and POST /config support #283

Conversation

theill commented Feb 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Feb 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Feb 8, 2016

facebook-github-bot commented Feb 8, 2016

facebook-github-bot commented Feb 8, 2016

Choose a reason for hiding this comment

drew-gross commented Feb 9, 2016

facebook-github-bot commented Feb 9, 2016

facebook-github-bot commented Feb 9, 2016

facebook-github-bot commented Feb 9, 2016

facebook-github-bot commented Feb 11, 2016

facebook-github-bot commented Feb 11, 2016

douineauromain commented Feb 16, 2016

drew-gross commented Feb 16, 2016

sghamaty commented Feb 16, 2016

gfosco commented Feb 16, 2016

sghamaty commented Feb 16, 2016

drew-gross commented Feb 17, 2016

sghamaty commented Feb 17, 2016

douineauromain commented Feb 26, 2016

gfosco commented Feb 26, 2016