Let multiple installations be updates if no critical values are set #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
force-pushed
the
fix/push-update-multiple
branch
from
db61d7d to
734a75c
Compare
|
@flovilmart updated the pull request - view changes |
| @@ -567,6 +567,12 @@ RestWrite.prototype.handleInstallation = function() { | |||
| 'must be specified in this operation'); | |||
| } | |||
|
|
|||
| // Updating _Installation but not updating anything critical | |||
There was a problem hiding this comment.
installationId could still be set on line 595 so should this check moved after that?
flovilmart
force-pushed
the
fix/push-update-multiple
branch
from
734a75c to
fc04692
Compare
|
@flovilmart updated the pull request - view changes |
steven-supersolid
approved these changes
Nov 28, 2016
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 3, 2016
…arse-community#3040) * Let multiple installations be updates if no critical values are set * nits
Jcarlosjunior
pushed a commit
to back4app/parse-server
that referenced
this pull request
Dec 13, 2016
…arse-community#3040) * Let multiple installations be updates if no critical values are set * nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2903
Fixes #3036
When sending push with badge, multiple installations may be updated, and blocked by the RESTWrite implementation.
This PR ensures that when not critical update is done to the _Installation, the safeguards are skipped.