Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can now login with email address instead of username #3639

Closed
wants to merge 1 commit into from
Closed

Users can now login with email address instead of username #3639

wants to merge 1 commit into from

Conversation

vince1995
Copy link
Contributor

Edited UsersRouter so users can now also login with their email addresses

@acinader
Copy link
Contributor

Hi @vince1995

Your pr is causing the tests to fail. You can check your code by running npm test

in this case the problem is that it is failing the lint check. npm run lint

@acinader
Copy link
Contributor

this also looks like it is a duplicate of: #3612

@flovilmart
Copy link
Contributor

@vince1995 closing as it doesn't fit what we'd expect for that feature, please refer to #3612 for more informations on how we'd like that feature to be integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants