Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3717 #3824

Merged
merged 3 commits into from
May 20, 2017
Merged

Fixes #3717 #3824

merged 3 commits into from
May 20, 2017

Conversation

felipeandradebezerra
Copy link
Contributor

This fixes PR #3717. Sending push with parse-server@2.4.0 returns error
504 GATEWAY_TIMEOUT. This happens when push_time is not set (default).

This fixes PR #3717. Sending push with parse-server@2.4.0 returns error
504 GATEWAY_TIMEOUT. This happens when push_time is not set (default).
@flovilmart
Copy link
Contributor

flovilmart commented May 16, 2017 via email

@flovilmart
Copy link
Contributor

We should also probably add a test for that just in case it ends up in production :)

@felipeandradebezerra
Copy link
Contributor Author

Kkkkkk... Lint?! How can I check that?

@flovilmart
Copy link
Contributor

Running npm test will run the lint first :)

Felipe Andrade added 2 commits May 17, 2017 11:02
Add a test to check push_time format and if it should schedule push
when the parse-server is configured
@felipeandradebezerra
Copy link
Contributor Author

I'm getting used to work with parse-server :-)

@felipeandradebezerra
Copy link
Contributor Author

HI @flovilmart Did I miss anything? :-)

@codecov
Copy link

codecov bot commented May 19, 2017

Codecov Report

Merging #3824 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3824      +/-   ##
==========================================
+ Coverage   90.16%   90.17%   +0.01%     
==========================================
  Files         114      114              
  Lines        7532     7534       +2     
==========================================
+ Hits         6791     6794       +3     
+ Misses        741      740       -1
Impacted Files Coverage Δ
src/Controllers/PushController.js 95.52% <100%> (+0.13%) ⬆️
src/RestWrite.js 93.26% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a2d26...11e2a9f. Read the comment docs.

@flovilmart
Copy link
Contributor

Looking good, it is working well for you?

@felipeandradebezerra
Copy link
Contributor Author

felipeandradebezerra commented May 20, 2017

@flovilmart I think it is, will double check. Anyway, I sent you an email early this week with some questions concerning running and testing parse-server.

@flovilmart
Copy link
Contributor

Yes! I've been pretty busy this week, I'll get back to you soon :) I'll double check also alongside the fix you provided in Parse-server

@flovilmart flovilmart merged commit 03b6449 into parse-community:master May 20, 2017
@felipeandradebezerra
Copy link
Contributor Author

felipeandradebezerra commented May 20, 2017

Everything is working in this PR.

@felipeandradebezerra
Copy link
Contributor Author

I think we also need to improve parse-server's CONTRIBUTING.MD with a handy guide for debugging our own stuff, so that we can work on it and test it iteratively without having to continually rebuild (see Parse-Dashboard example).

I've used the following steps to work on Parse-Server.

Step 1 — Install Parse Server app example

Retrieve the repository with git:
$ git clone https://github.com/ParsePlatform/parse-server-example.git

Step 2 - Declare your local dependencies in package.json
https://github.com/parse-community/parse-server-example/blob/master/package.json#L15
change to
"parse-server": "file:/Users/Colubris/Learning/parse-server",

Step 3 - Install and Run
Use npm to install dependencies, including your parse-server, in the parse-server-example directory:
$ npm install

Use npm to start the service. In this case, it runs node index.js:
$ npm start

Please, let me know if I'm following the right path. Thanks!

@flovilmart
Copy link
Contributor

You should just have cloned Parse-server and run npm start :)

@felipeandradebezerra
Copy link
Contributor Author

Hahaha... I think I'm getting older :-/

parse-server path/to/config.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants