Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bytes to Schema #3894

Merged
merged 7 commits into from
Jun 1, 2017
Merged

Add Bytes to Schema #3894

merged 7 commits into from
Jun 1, 2017

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jun 1, 2017

I was using the php sdk and noticed the ParseBytes were failing against postgres.

And bytes weren't showing up in my dashboard.

This PR adds Byte support for PG and Mongo Schema.

The issue was the Bytes Schema had a __op delete when its created. Which made the schema delete it
when ever you fetch it.

Let me know if more tests are needed for this.

@codecov
Copy link

codecov bot commented Jun 1, 2017

Codecov Report

Merging #3894 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3894      +/-   ##
==========================================
+ Coverage   90.25%   90.25%   +<.01%     
==========================================
  Files         114      114              
  Lines        7582     7584       +2     
==========================================
+ Hits         6843     6845       +2     
  Misses        739      739
Impacted Files Coverage Δ
src/Controllers/SchemaController.js 97.04% <100%> (ø) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.83% <100%> (+0.14%) ⬆️
...rc/Adapters/Storage/Mongo/MongoSchemaCollection.js 95.89% <100%> (+1.44%) ⬆️
src/rest.js 97.01% <0%> (-1.5%) ⬇️
src/Adapters/Storage/Mongo/MongoTransform.js 82.98% <0%> (-0.22%) ⬇️
src/RestWrite.js 93.12% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8be98d...b5d6f8f. Read the comment docs.

@flovilmart
Copy link
Contributor

I don't think more tests are needed, as it's covered by the other cases! Thanks!

@flovilmart flovilmart merged commit 4b16a72 into parse-community:master Jun 1, 2017
@flovilmart flovilmart modified the milestone: 2.5.0 Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants