Server info proper values #3933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3933 +/- ##
==========================================
+ Coverage 90.41% 90.44% +0.02%
==========================================
Files 114 114
Lines 7682 7682
==========================================
+ Hits 6946 6948 +2
+ Misses 736 734 -2
Continue to review full report at Codecov.
|
acinader
previously approved these changes
Jun 15, 2017
Contributor
acinader
left a comment
acinader
left a comment
There was a problem hiding this comment.
Unless you have a reason to leave in the commented out old logic, please remove.
src/ParseServer.js
Outdated
| const hasPushScheduledSupport = pushAdapter && push && scheduledPush; | ||
| const hasPushSupport = (pushAdapter && push) != undefined; | ||
| const hasPushScheduledSupport = hasPushSupport && (scheduledPush == true); | ||
| //const hasPushSupport = pushAdapter && push; |
src/ParseServer.js
Outdated
| const hasPushSupport = pushAdapter && push; | ||
| const hasPushScheduledSupport = pushAdapter && push && scheduledPush; | ||
| const hasPushSupport = (pushAdapter && push) != undefined; | ||
| const hasPushScheduledSupport = hasPushSupport && (scheduledPush == true); |
Contributor
There was a problem hiding this comment.
whoa. i just tested undefined && undefined in the node repl. never would have guessed that. nice.
Contributor
Author
|
Yeah that's a bit silly! |
acinader
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.