Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting read preference when using rest api. #3959

Closed

Conversation

acinader
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2017

Codecov Report

Merging #3959 into master will decrease coverage by 5.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3959      +/-   ##
==========================================
- Coverage   90.59%   85.35%   -5.24%     
==========================================
  Files         115      115              
  Lines        7784     7786       +2     
==========================================
- Hits         7052     6646     -406     
- Misses        732     1140     +408
Impacted Files Coverage Δ
src/Routers/ClassesRouter.js 94.59% <100%> (+1.53%) ⬆️
src/Adapters/Files/GridStoreAdapter.js 17.85% <0%> (-67.86%) ⬇️
src/Adapters/Storage/Mongo/MongoCollection.js 48.78% <0%> (-46.35%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 46.03% <0%> (-46.04%) ⬇️
src/Adapters/Storage/Mongo/MongoTransform.js 41.85% <0%> (-41.65%) ⬇️
src/Routers/SessionsRouter.js 63.41% <0%> (-26.83%) ⬇️
...rc/Adapters/Storage/Mongo/MongoSchemaCollection.js 76.71% <0%> (-19.18%) ⬇️
src/Adapters/Cache/RedisCacheAdapter.js 76.59% <0%> (-14.9%) ⬇️
src/Auth.js 91.07% <0%> (-8.93%) ⬇️
src/ParseServer.js 83.54% <0%> (-5.07%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6816c...014cfe0. Read the comment docs.

@davimacedo
Copy link
Member

It is fine to me when talking about GET, but it is missing for FIND. I also added some tests. Take a look here:
#3963

@acinader acinader closed this Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants