Skip to content

Add support for $centerSphere queries #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add support for $centerSphere queries #4060

wants to merge 4 commits into from

Conversation

madsb
Copy link
Contributor

@madsb madsb commented Jul 28, 2017

This commit adds support for $centerSphere queries, effectively deprecating $nearSphere/$maxDistance queries, which makes way for the use of 2dsphere indexes and GeoJSON objects for queries like $geoIntersects (#3942).

Parse JS SDK also has a pull request re. this change: parse-community/Parse-SDK-JS#467

commit fc79959846a59a38009ca7babeb3e0e9fd989441
Author: Mads Bjerre <mads@wisekopf.com>
Date:   Fri Jul 28 13:02:32 2017 +0200

    Add tests for withinCenterSphere queries

commit 57d3216895df6decc8c3a50a9aca5ccf7b545d9c
Author: Mads Bjerre <mads@wisekopf.com>
Date:   Fri Jul 28 13:02:12 2017 +0200

    Whitespace

commit e5f7249488b8e8a7b1ec9e292febd944c8f734e2
Author: Mads Bjerre <mads@wisekopf.com>
Date:   Thu Jul 27 17:10:11 2017 +0200

    Add $centerSphere shape to $geoWithin query
@madsb madsb changed the title Add support for withinCenterSphere queries Add support for $centerSphere queries Jul 28, 2017
madsb added 3 commits July 28, 2017 15:21
local testing and remote testing apparently has different settings for indentations
@codecov
Copy link

codecov bot commented Jul 29, 2017

Codecov Report

Merging #4060 into master will decrease coverage by 0.09%.
The diff coverage is 56.52%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4060     +/-   ##
========================================
- Coverage    90.7%   90.6%   -0.1%     
========================================
  Files         116     116             
  Lines        7916    7928     +12     
========================================
+ Hits         7180    7183      +3     
- Misses        736     745      +9
Impacted Files Coverage Δ
src/vendor/mongodbUrl.js 100% <ø> (ø) ⬆️
src/Adapters/Storage/Mongo/MongoTransform.js 82.96% <56.52%> (-1.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d51de...a06ed0a. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 29, 2017

Codecov Report

Merging #4060 into master will decrease coverage by 0.09%.
The diff coverage is 56.52%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4060     +/-   ##
========================================
- Coverage    90.7%   90.6%   -0.1%     
========================================
  Files         116     116             
  Lines        7916    7928     +12     
========================================
+ Hits         7180    7183      +3     
- Misses        736     745      +9
Impacted Files Coverage Δ
src/vendor/mongodbUrl.js 100% <ø> (ø) ⬆️
src/Adapters/Storage/Mongo/MongoTransform.js 82.96% <56.52%> (-1.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d51de...a06ed0a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant