withinPolygon support for Polygon object #4067
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4067 +/- ##
=========================================
+ Coverage 92.68% 92.7% +0.02%
=========================================
Files 119 119
Lines 8663 8679 +16
=========================================
+ Hits 8029 8046 +17
+ Misses 634 633 -1
Continue to review full report at Codecov.
|
spec/ParseGeoPoint.spec.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('support $geoIntersects queries', (done) => { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Indeed it does. Duplicate removed.
|
I can see the tests are failing with postgres, but I'm not that well versed with that database. If someone is able to fix the tests I'd be grateful. |
| if (polygon.length < 3) { | ||
| let points | ||
| if (typeof polygon === 'object' && polygon.__type === 'Polygon') { | ||
| if (!polygon.coordinates && polygon.coordinates.length < 3) { |
There was a problem hiding this comment.
!polygon.coordinates || polygon.coordinates.length < 3
Using OR here instead of AND passes test. You might want to do the same with mongo and check your logic
spec/ParseGeoPoint.spec.js
Outdated
| fail(`no request should succeed: ${JSON.stringify(resp)}`); | ||
| done(); | ||
| }).catch((err) => { | ||
| expect(err.error.code).toEqual(1); |
There was a problem hiding this comment.
Error should be 107 or Parse.Error.INVALID_JSON
|
@madsb ping? |
|
@flovilmart I added |
|
That sounds rad. What’s next on this one? |
|
@madsb How does this look? @flovilmart I think this is good to go. |
* Whitespace * Add Polygon type to $polygon query * Add tests Polygon object in $polygon query $geoIntersects queries * Refactor * Postgres support * More tests * Remove duplicate test * Missing semicolon * fix tests
3 participants
This pull request add support for
Polygonobjects besides arrays ofGeoPoints.