Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance optimization #4488

Closed
wants to merge 3 commits into from
Closed

performance optimization #4488

wants to merge 3 commits into from

Conversation

vitaly-t
Copy link
Contributor

@vitaly-t vitaly-t commented Jan 7, 2018

faster query formatting + execution.

faster query formatting + execution.
fixing the issue with the open query text.
@vitaly-t
Copy link
Contributor Author

vitaly-t commented Jan 8, 2018

Struggling to understand why it is failing,... the error log is of no use, as it points at the wrong line 431. 😕

@montymxb
Copy link
Contributor

Hmmm, might I suggest checking those optimizations one at a time to isolate? Might help pin it down a bit.

@codecov
Copy link

codecov bot commented Jan 15, 2018

Codecov Report

Merging #4488 into master will decrease coverage by 11.48%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4488       +/-   ##
===========================================
- Coverage   92.81%   81.33%   -11.49%     
===========================================
  Files         118      118               
  Lines        8394     8384       -10     
===========================================
- Hits         7791     6819      -972     
- Misses        603     1565      +962
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.88% <0%> (-94.23%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 7.14% <0%> (-78.58%) ⬇️
src/Controllers/UserController.js 91.5% <0%> (-0.95%) ⬇️
src/Routers/UsersRouter.js 92.53% <0%> (-0.75%) ⬇️
src/RestWrite.js 93.28% <0%> (-0.37%) ⬇️
src/Controllers/DatabaseController.js 94.36% <0%> (-0.21%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 95.78% <0%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33890bb...ff27788. Read the comment docs.

@vitaly-t
Copy link
Contributor Author

Closing, because I'm not likely to have time for this PR in any near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants