Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark the empty pushs as failed #4497

Merged
merged 1 commit into from
Jan 13, 2018

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 13, 2018

Codecov Report

Merging #4497 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4497      +/-   ##
==========================================
- Coverage   92.89%   92.79%   -0.11%     
==========================================
  Files         118      118              
  Lines        8394     8394              
==========================================
- Hits         7798     7789       -9     
- Misses        596      605       +9
Impacted Files Coverage Δ
src/Push/PushQueue.js 100% <100%> (ø) ⬆️
src/Adapters/Cache/InMemoryCache.js 91.66% <0%> (-8.34%) ⬇️
src/Adapters/Auth/meetup.js 84.21% <0%> (-5.27%) ⬇️
src/Routers/UsersRouter.js 93.28% <0%> (-0.75%) ⬇️
src/RestWrite.js 93.46% <0%> (-0.37%) ⬇️
src/Adapters/Storage/Mongo/MongoTransform.js 85.4% <0%> (-0.33%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.01% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec07b8...19f6dd3. Read the comment docs.

@dplewis
Copy link
Member

dplewis commented Jan 13, 2018

LGTM!

@flovilmart
Copy link
Contributor Author

Closes #4496

@flovilmart flovilmart merged commit 33890bb into master Jan 13, 2018
@flovilmart flovilmart deleted the fix-4496/mark-empty-push-success branch January 13, 2018 20:12
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants