Skip to content

chore: Specify db adapter properly in postgres flaky test #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Mar 11, 2018

Closes: #4294

@codecov
Copy link

codecov bot commented Mar 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0b69700). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4630   +/-   ##
=========================================
  Coverage          ?   92.68%           
=========================================
  Files             ?      119           
  Lines             ?     8567           
  Branches          ?        0           
=========================================
  Hits              ?     7940           
  Misses            ?      627           
  Partials          ?        0
Impacted Files Coverage Δ
src/Routers/PurgeRouter.js 84.61% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b69700...9d91ef7. Read the comment docs.

dplewis
dplewis previously approved these changes Mar 12, 2018
@dplewis
Copy link
Member

dplewis commented Mar 23, 2018

@flovilmart I know I've asked you this before but how do you go about fixing these flaky tests?

For instance how did you figure out this is a solution to

Failed: cannot perform operation: a background operation is currently running for collection parse._User

@flovilmart
Copy link
Contributor Author

I didn't find a solution per se, just out of luck hopefull it will fix the flaky test ;) not sure ;)

@dplewis
Copy link
Member

dplewis commented Mar 23, 2018

lol lets give it a shot

@flovilmart flovilmart closed this May 1, 2018
@flovilmart flovilmart deleted the postgres-flaky-test branch May 1, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants