Skip to content

Remove sigkill and sigint handler added to overcome a long closed issue with node #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove sigkill and sigint handler added to overcome a long closed issue with node #4635

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfff792
Tell the process to exit once our shutdown hook has run.
acinader Mar 11, 2018
c825802
rip out the special handeling that is no longer needed because https:…
acinader Mar 16, 2018
b1c09ce
Merge branch 'master' into shutdown-livequery
acinader Mar 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 1 addition & 37 deletions src/ParseServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,7 @@ class ParseServer {
if (options.startLiveQueryServer || options.liveQueryServerOptions) {
this.liveQueryServer = ParseServer.createLiveQueryServer(server, options.liveQueryServerOptions);
}
/* istanbul ignore next */
if (!process.env.TESTING) {
configureListeners(this);
}

this.expressApp = app;
return this;
}
Expand Down Expand Up @@ -310,37 +307,4 @@ function injectDefaults(options: ParseServerOptions) {
)));
}

// Those can't be tested as it requires a subprocess
/* istanbul ignore next */
function configureListeners(parseServer) {
const server = parseServer.server;
const sockets = {};
/* Currently, express doesn't shut down immediately after receiving SIGINT/SIGTERM if it has client connections that haven't timed out. (This is a known issue with node - https://github.com/nodejs/node/issues/2642)
This function, along with `destroyAliveConnections()`, intend to fix this behavior such that parse server will close all open connections and initiate the shutdown process as soon as it receives a SIGINT/SIGTERM signal. */
server.on('connection', (socket) => {
const socketId = socket.remoteAddress + ':' + socket.remotePort;
sockets[socketId] = socket;
socket.on('close', () => {
delete sockets[socketId];
});
});

const destroyAliveConnections = function() {
for (const socketId in sockets) {
try {
sockets[socketId].destroy();
} catch (e) { /* */ }
}
}

const handleShutdown = function() {
process.stdout.write('Termination signal received. Shutting down.');
destroyAliveConnections();
server.close();
parseServer.handleShutdown();
};
process.on('SIGTERM', handleShutdown);
process.on('SIGINT', handleShutdown);
}

export default ParseServer;