Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making response.error accept a Parse.Error object as parameter #4695

Merged
merged 2 commits into from
May 18, 2018
Merged

Making response.error accept a Parse.Error object as parameter #4695

merged 2 commits into from
May 18, 2018

Conversation

saulogt
Copy link
Contributor

@saulogt saulogt commented Apr 2, 2018

Passing the original Parse.Error has the obvious benefit of preventing the re-creation of it.
Additionally, it can take advantage of keeping extra fields in the object such as the stack.

For example:
https://github.com/saulogt/parse-error-plus
I use this module (I'm the author) that makes Parse.Error a subclass o Error. It's being useful to trace the error when it happens, but the stack is reset when request.error is called.

@flovilmart
Copy link
Contributor

Thanks for the PR"

@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #4695 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4695   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files         119      119           
  Lines        8585     8585           
=======================================
  Hits         7955     7955           
  Misses        630      630
Impacted Files Coverage Δ
src/triggers.js 93.8% <50%> (-0.43%) ⬇️
src/Routers/FunctionsRouter.js 93.42% <50%> (-1.18%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.14% <0%> (-0.1%) ⬇️
src/Controllers/SchemaController.js 96.47% <0%> (-0.02%) ⬇️
src/Controllers/DatabaseController.js 94.58% <0%> (-0.02%) ⬇️
src/Routers/UsersRouter.js 93.02% <0%> (ø) ⬆️
src/RestWrite.js 93.6% <0%> (+0.18%) ⬆️
src/Adapters/Cache/InMemoryCache.js 100% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c357df...1b04125. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants