Skip to content

Always use http-agent for hooks and triggers #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

TylerBrock
Copy link
Contributor

Follow up given discussion on #4791

@TylerBrock TylerBrock requested review from flovilmart and acinader May 31, 2018 19:10
@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #4800 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4800      +/-   ##
==========================================
+ Coverage   92.68%   92.69%   +<.01%     
==========================================
  Files         119      119              
  Lines        8686     8684       -2     
==========================================
- Hits         8051     8050       -1     
+ Misses        635      634       -1
Impacted Files Coverage Δ
src/Options/Definitions.js 100% <ø> (ø) ⬆️
src/Controllers/index.js 96.55% <100%> (ø) ⬆️
src/Controllers/HooksController.js 96.33% <100%> (+1.73%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.15% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bff44b...08cf637. Read the comment docs.

@flovilmart
Copy link
Contributor

Makes sense! Let's go with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants