Skip to content

Even faster tests #4868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Even faster tests #4868

merged 3 commits into from
Jul 3, 2018

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Jul 3, 2018

before after
capture d ecran le 2018-07-02 a 23 21 06 capture d ecran le 2018-07-02 a 23 43 10
-timing- -timing-
~8:30 ~5:30

@flovilmart flovilmart changed the base branch from no-babel-register to master July 3, 2018 03:10
@flovilmart flovilmart closed this Jul 3, 2018
@flovilmart flovilmart reopened this Jul 3, 2018
@flovilmart flovilmart requested a review from acinader July 3, 2018 03:30
@flovilmart flovilmart force-pushed the event-faster-tests branch from 50d4d3f to dfeed12 Compare July 3, 2018 03:31
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #4868 into master will decrease coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4868      +/-   ##
==========================================
- Coverage   92.94%   92.93%   -0.01%     
==========================================
  Files         119      119              
  Lines        8815     8821       +6     
==========================================
+ Hits         8193     8198       +5     
- Misses        622      623       +1
Impacted Files Coverage Δ
src/Controllers/DatabaseController.js 94.69% <ø> (ø) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.2% <ø> (-0.01%) ⬇️
src/TestUtils.js 87.5% <100%> (ø) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.01% <88.88%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1a822...6327bbc. Read the comment docs.

@flovilmart flovilmart force-pushed the event-faster-tests branch from dfeed12 to 23e1819 Compare July 3, 2018 03:57
…lete data for mongo

- Speeds up are incredible Executed 1695 of 1713 specs INCOMPLETE (18 PENDING) in 4 mins 19 secs.
@flovilmart flovilmart force-pushed the event-faster-tests branch from 23e1819 to c727771 Compare July 3, 2018 04:12
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this look good. can you add a comment to destroyAllDataPermanently(fast) explaining what the fast does and why you would use or not?

@flovilmart
Copy link
Contributor Author

Yep I can do that!

@acinader acinader changed the title Event faster tests Even faster tests Jul 3, 2018
@flovilmart flovilmart merged commit 960431b into master Jul 3, 2018
@flovilmart flovilmart deleted the event-faster-tests branch July 3, 2018 15:13
@dplewis
Copy link
Member

dplewis commented Jul 4, 2018

Damn it Florient. You're a god damn genius!!

damn-it-gump-youre-a-damn-genius

@flovilmart
Copy link
Contributor Author

AHhaha :) thanks @dplewis ! :) This is quite fast indeed!

flovilmart added a commit that referenced this pull request Aug 12, 2018
* Various improvements in test name / de-duplications

* Reverts to class by class deletion, introduced fast mode that just delete data for mongo

- Speeds up are incredible Executed 1695 of 1713 specs INCOMPLETE (18 PENDING) in 4 mins 19 secs.

* Adds documentation about the deleteEverything
flovilmart added a commit that referenced this pull request Aug 12, 2018
* Various improvements in test name / de-duplications

* Reverts to class by class deletion, introduced fast mode that just delete data for mongo

- Speeds up are incredible Executed 1695 of 1713 specs INCOMPLETE (18 PENDING) in 4 mins 19 secs.

* Adds documentation about the deleteEverything
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Various improvements in test name / de-duplications

* Reverts to class by class deletion, introduced fast mode that just delete data for mongo

- Speeds up are incredible Executed 1695 of 1713 specs INCOMPLETE (18 PENDING) in 4 mins 19 secs.

* Adds documentation about the deleteEverything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants