Skip to content

Getting ready for JS SDK 2.0 #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 5, 2018
Merged

Getting ready for JS SDK 2.0 #4925

merged 7 commits into from
Aug 5, 2018

Conversation

flovilmart
Copy link
Contributor

No description provided.

@flovilmart flovilmart requested review from acinader and dplewis August 3, 2018 03:38
acinader
acinader previously approved these changes Aug 3, 2018
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tests failing.

@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #4925 into master will decrease coverage by 0.06%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4925      +/-   ##
==========================================
- Coverage   92.96%   92.89%   -0.07%     
==========================================
  Files         119      119              
  Lines        8837     8835       -2     
==========================================
- Hits         8215     8207       -8     
- Misses        622      628       +6
Impacted Files Coverage Δ
src/cloud-code/httpRequest.js 100% <100%> (ø) ⬆️
src/LiveQuery/ParseLiveQueryServer.js 86.55% <100%> (ø) ⬆️
src/LiveQuery/SessionTokenCache.js 86.95% <60%> (ø) ⬆️
src/ParseServerRESTController.js 95.12% <87.5%> (ø) ⬆️
src/Adapters/Auth/meetup.js 84.21% <0%> (-5.27%) ⬇️
src/RestWrite.js 92.96% <0%> (-0.73%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.2% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a61ef7e...80e2d83. Read the comment docs.

@flovilmart
Copy link
Contributor Author

Yay! Let's merge this one we'll need to release the next version of the server as 3.0.0 and update the docs as well :)

@flovilmart flovilmart merged commit ff25ae2 into master Aug 5, 2018
@flovilmart flovilmart deleted the sdk-js-2 branch August 5, 2018 17:58
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* WIP: Integrate JS SDK v2

- Removes backbone style callbacks
- Use Promise instead of Parse.Promise

* Fixes ParseObject and ParseRelation

* Updates Parse.Query with promises

* Alls tests should pass

* Ensure a fresh user is used for each test

* Use REST implementation to avoid side effects for username/email duplicates

* Uses js sdk v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants