Skip to content

PG: Support multiple global config #5242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Dec 14, 2018

Closes: #5176

Fixes dot notation support on postgres.

Allows for more than one config

Add support for setting key of type object.

@dplewis dplewis changed the title Pg multiple config PG: Support multiple global config Dec 14, 2018
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #5242 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5242      +/-   ##
==========================================
- Coverage   93.91%   93.87%   -0.04%     
==========================================
  Files         123      123              
  Lines        8939     8950      +11     
==========================================
+ Hits         8395     8402       +7     
- Misses        544      548       +4
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.11% <100%> (-0.06%) ⬇️
src/Routers/PushRouter.js 92.85% <0%> (-3.58%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 91.48% <0%> (-0.73%) ⬇️
src/RestWrite.js 93.24% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c419ec...1285ea8. Read the comment docs.

@dplewis dplewis requested a review from flovilmart December 14, 2018 22:19
Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean it allows for more than one config?

@dplewis
Copy link
Member Author

dplewis commented Dec 14, 2018

On Postgres you can only have one Parse.Config, this fixes that issue

@dplewis dplewis merged commit d478e00 into parse-community:master Dec 14, 2018
@dplewis dplewis deleted the pg-multiple-config branch December 14, 2018 23:39
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* PG: Support Multiple Configs

* rename test

* refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants