Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode Date JSON value at LiveQuery #5540

Merged
merged 1 commit into from
Apr 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions spec/QueryTools.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -587,4 +587,49 @@ describe('matchesQuery', function() {
q.notContainedIn('profile', ['abc', 'def', 'ghi']);
expect(matchesQuery(message, q)).toBe(false);
});

it('matches on Date', () => {
// given
const now = new Date();
const obj = {
id: new Id('Person', '01'),
dateObject: now,
dateJSON: {
__type: 'Date',
iso: now.toISOString(),
},
};

// when, then: Equal
let q = new Parse.Query('Person');
q.equalTo('dateObject', now);
q.equalTo('dateJSON', now);
expect(matchesQuery(Object.assign({}, obj), q)).toBe(true);

// when, then: lessThan
const future = Date(now.getTime() + 1000);
dplewis marked this conversation as resolved.
Show resolved Hide resolved
q = new Parse.Query('Person');
q.lessThan('dateObject', future);
q.lessThan('dateJSON', future);
expect(matchesQuery(Object.assign({}, obj), q)).toBe(true);

// when, then: lessThanOrEqualTo
q = new Parse.Query('Person');
q.lessThanOrEqualTo('dateObject', now);
q.lessThanOrEqualTo('dateJSON', now);
expect(matchesQuery(Object.assign({}, obj), q)).toBe(true);

// when, then: greaterThan
const past = Date(now.getTime() - 1000);
q = new Parse.Query('Person');
q.greaterThan('dateObject', past);
q.greaterThan('dateJSON', past);
expect(matchesQuery(Object.assign({}, obj), q)).toBe(true);

// when, then: greaterThanOrEqualTo
q = new Parse.Query('Person');
q.greaterThanOrEqualTo('dateObject', now);
q.greaterThanOrEqualTo('dateJSON', now);
expect(matchesQuery(Object.assign({}, obj), q)).toBe(true);
});
});
4 changes: 4 additions & 0 deletions src/LiveQuery/QueryTools.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ function matchesKeyConstraints(object, key, constraints) {
// Bail! We can't handle relational queries locally
return false;
}
// Decode Date JSON value
if (object[key] && object[key].__type == 'Date') {
object[key] = new Date(object[key].iso);
}
// Equality (or Array contains) cases
if (typeof constraints !== 'object') {
if (Array.isArray(object[key])) {
Expand Down