Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed logger not applying timestamp to logs #5561

Closed
wants to merge 2 commits into from
Closed

fixed logger not applying timestamp to logs #5561

wants to merge 2 commits into from

Conversation

srowe0091
Copy link

Fix for issue #5560

Basically Winston was updated to 3.x which changed timestamp is to be used. This PR adds the timestamp back to the logs.

@srowe0091
Copy link
Author

srowe0091 commented May 4, 2019

I'll fix the broken test, but actually not sure how to test a timestamp, any ideas?

@dplewis
Copy link
Member

dplewis commented May 5, 2019

There are existing tests https://github.com/parse-community/parse-server/blob/master/spec/Logger.spec.js

Check the Travis logs for failing tests

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #5561 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5561      +/-   ##
==========================================
- Coverage   94.07%   94.04%   -0.03%     
==========================================
  Files         129      129              
  Lines        9192     9192              
==========================================
- Hits         8647     8645       -2     
- Misses        545      547       +2
Impacted Files Coverage Δ
src/Adapters/Logger/WinstonLogger.js 100% <100%> (ø) ⬆️
src/RestWrite.js 93.19% <0%> (-0.18%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.98% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b0093...c8e46df. Read the comment docs.

@acinader
Copy link
Contributor

acinader commented May 8, 2019

The only test that is still failing is due to the fact that with this change, the console log now has a timestamp and the test isn't expecting that. I'm going to investigate, but just confirming the test to the new output wouldn't be bad, imho

@dplewis
Copy link
Member

dplewis commented May 9, 2019

Closing via #5571

@mrowe009 Thanks for getting started on this and doing most of the heavy lifting.

@dplewis dplewis closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants