-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres: Regex support foreign characters #5598
Conversation
Can you add a test to prevent regression? It should work for mongo as welll |
@dplewis Sure. I will update again following the contributing guide. |
Codecov Report
@@ Coverage Diff @@
## master #5598 +/- ##
==========================================
- Coverage 94.05% 94.04% -0.01%
==========================================
Files 143 143
Lines 10094 10095 +1
==========================================
Hits 9494 9494
- Misses 600 601 +1
Continue to review full report at Codecov.
|
This reverts commit 38b32a6.
@dplewis since we're in node here and not the browser, we don't need to add the lib xregexp. Can just use RegExp with the 'u' flag. Here's a test to show it: https://runkit.com/arthur/regex-unicode-example thanks for picking this up. It's important. I shoulda caught it.... |
* Fix issue parse-community#5293 * Fix issue parse-community#5293 * add test * Revert "add test" This reverts commit 38b32a6. * fix conflicts * use native package
Fix issue #5293