Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres: Regex support foreign characters #5598

Merged
merged 8 commits into from
Jun 24, 2019

Conversation

JeffGuKang
Copy link
Contributor

@JeffGuKang JeffGuKang commented May 16, 2019

Fix issue #5293

@JeffGuKang JeffGuKang changed the title Fix issue parse-community#5293 Fix issue #5293 May 16, 2019
@dplewis
Copy link
Member

dplewis commented May 16, 2019

Can you add a test to prevent regression? It should work for mongo as welll

@JeffGuKang
Copy link
Contributor Author

@dplewis Sure. I will update again following the contributing guide.

@dplewis dplewis changed the title Fix issue #5293 Postgres: Regex support foreign characters May 30, 2019
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #5598 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5598      +/-   ##
==========================================
- Coverage   94.05%   94.04%   -0.01%     
==========================================
  Files         143      143              
  Lines       10094    10095       +1     
==========================================
  Hits         9494     9494              
- Misses        600      601       +1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.9% <100%> (ø) ⬆️
src/RestWrite.js 93.49% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b178d5c...db317b8. Read the comment docs.

@dplewis dplewis closed this Jun 12, 2019
@dplewis dplewis reopened this Jun 12, 2019
@dplewis dplewis requested a review from acinader June 24, 2019 20:11
@acinader
Copy link
Contributor

@dplewis since we're in node here and not the browser, we don't need to add the lib xregexp.

Can just use RegExp with the 'u' flag. Here's a test to show it: https://runkit.com/arthur/regex-unicode-example

thanks for picking this up. It's important. I shoulda caught it....

@dplewis dplewis merged commit ad7fc48 into parse-community:master Jun 24, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Fix issue parse-community#5293

* Fix issue parse-community#5293

* add test

* Revert "add test"

This reverts commit 38b32a6.

* fix conflicts

* use native package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants