-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rest option: excludeKeys #5737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Just a few changes
Sure. I will aply the changes as soon as I get a chance. |
Codecov Report
@@ Coverage Diff @@
## master #5737 +/- ##
==========================================
- Coverage 93.67% 93.64% -0.04%
==========================================
Files 145 145
Lines 10188 10229 +41
==========================================
+ Hits 9544 9579 +35
- Misses 644 650 +6
Continue to review full report at Codecov.
|
@RaschidJFR Thanks for the PR. I cleaned it up and add more tests to get this into the next release. @acinader how does this look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhmazing
Great, I'm glad it was useful. I'm paying clsoe attention to the process and tests so the next PR need less changes. |
Yeah the SDK's and the Docs are next. Adding new features like this takes a lot of time. We can wait until the server release. |
* Added restOption: excludeKeys * improve tests
Added support for rest parameter
excludeKeys
in queries (similar tokeys
) in order to exclude the desired fields from retrieved objects.Fixes #4948