Skip to content

Don't require redis for local tests #5797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Don't require redis for local tests #5797

merged 1 commit into from
Jul 10, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 10, 2019

Closes: #5794

Prevents redis from being required in local tests.

@dplewis dplewis requested a review from acinader July 10, 2019 19:01
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #5797 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5797   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files         145      145           
  Lines       10212    10212           
=======================================
  Hits         9561     9561           
  Misses        651      651
Impacted Files Coverage Δ
src/RestWrite.js 93.15% <0%> (-0.18%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.9% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ce9e1...a875cbd. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Jul 10, 2019

@acinader Can you pull it down and see if it works?

@acinader acinader changed the title Fix #5794 Don't require redis for local tests Jul 10, 2019
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm. thanks!

@acinader acinader merged commit 378e70a into master Jul 10, 2019
@acinader acinader deleted the fix-5794 branch July 10, 2019 19:19
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis now required to run unit tests locally
2 participants