Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "count" operation not respecting CLP #5819

Conversation

douglasmuraoka
Copy link
Contributor

No description provided.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like we talked, I think that the problem is not the way that the current REST API is behaving, but the GraphQL API that is not behaving like the REST one. Can you please refactor?

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #5819 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5819      +/-   ##
==========================================
- Coverage   93.73%   93.71%   -0.02%     
==========================================
  Files         148      148              
  Lines       10296    10296              
==========================================
- Hits         9651     9649       -2     
- Misses        645      647       +2
Impacted Files Coverage Δ
src/Controllers/SchemaController.js 97.11% <100%> (+0.22%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 91.72% <0%> (-0.73%) ⬇️
src/RestWrite.js 93.51% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d5f6b4...11d94fa. Read the comment docs.

@davimacedo
Copy link
Member

@douglasmuraoka as we talked, it seems that parse-server is actually ready to handle different types of permissions for find and count on CLP besides the count option is not available at Parse Dashboard. Therefore, we agreed to close this PR and open an issue in Parse Dashboard to add the count option in the future.

@davimacedo davimacedo closed this Jul 19, 2019
@davimacedo
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants