Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL custom schema on CLI #5828

Merged
merged 6 commits into from
Jul 19, 2019

Conversation

davimacedo
Copy link
Member

This PR empowers Parse Server CLI with the option to read from a schema.graphql to create a custom GraphQL schema that will be merged to the auto-generated one.

@davimacedo davimacedo requested review from TomWFox and dplewis July 19, 2019 06:19
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor consistency suggestions

README.md Outdated Show resolved Hide resolved
src/Options/Definitions.js Outdated Show resolved Hide resolved
src/Options/docs.js Outdated Show resolved Hide resolved
src/Options/index.js Outdated Show resolved Hide resolved
Co-Authored-By: Tom Fox <tomfox@surprises.io>
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #5828 into master will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5828      +/-   ##
==========================================
- Coverage   93.75%   93.68%   -0.07%     
==========================================
  Files         148      148              
  Lines       10296    10301       +5     
==========================================
- Hits         9653     9651       -2     
- Misses        643      650       +7
Impacted Files Coverage Δ
src/Options/index.js 100% <ø> (ø) ⬆️
src/Options/Definitions.js 100% <ø> (ø) ⬆️
src/ParseServer.js 97.4% <83.33%> (-0.59%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 91.72% <0%> (-0.73%) ⬇️
src/RestWrite.js 93.34% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c809f5...c49d6d0. Read the comment docs.

davimacedo and others added 2 commits July 19, 2019 11:37
Co-Authored-By: Tom Fox <tomfox@surprises.io>
Co-Authored-By: Tom Fox <tomfox@surprises.io>
@ghost
Copy link

ghost commented Jul 19, 2019

Danger run resulted in 1 fail; to find out more, see the checks page.

Generated by 🚫 dangerJS

Co-Authored-By: Tom Fox <tomfox@surprises.io>
@davimacedo davimacedo merged commit a6f4412 into parse-community:master Jul 19, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Add --graphQLSchema to CLI

* Add custom graphql schema instructions to readme file

* Update README.md

Co-Authored-By: Tom Fox <tomfox@surprises.io>

* Update src/Options/Definitions.js

Co-Authored-By: Tom Fox <tomfox@surprises.io>

* Update src/Options/docs.js

Co-Authored-By: Tom Fox <tomfox@surprises.io>

* Update src/Options/index.js

Co-Authored-By: Tom Fox <tomfox@surprises.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants