Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache apple public key for the case it fails to fetch again #5848

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

davimacedo
Copy link
Member

@dplewis what do you think?

@dplewis
Copy link
Member

dplewis commented Jul 25, 2019

I'll do a PR to support private keys as well.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #5848 into master will decrease coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5848      +/-   ##
==========================================
- Coverage    93.7%   93.66%   -0.04%     
==========================================
  Files         148      148              
  Lines       10310    10315       +5     
==========================================
+ Hits         9661     9662       +1     
- Misses        649      653       +4
Impacted Files Coverage Δ
src/Adapters/Auth/apple.js 89.65% <57.14%> (-10.35%) ⬇️
src/Adapters/Auth/httpsRequest.js 95.23% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f1e8e...ec4a690. Read the comment docs.

@davimacedo davimacedo merged commit 8a92517 into parse-community:master Jul 25, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants