Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set falsy values as default to schema fields #5868

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

alencarlucas
Copy link
Contributor

@alencarlucas alencarlucas commented Jul 30, 2019

This PR fixes the issue that occurs when setting false or zero as the default value in a field. Tests were added.

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #5868 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5868      +/-   ##
=========================================
+ Coverage   93.68%   93.7%   +0.01%     
=========================================
  Files         153     153              
  Lines       10636   10636              
=========================================
+ Hits         9964    9966       +2     
+ Misses        672     670       -2
Impacted Files Coverage Δ
src/RestWrite.js 93.56% <ø> (-0.17%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.56% <0%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 218c349...4a08d49. Read the comment docs.

@dplewis dplewis merged commit 6080dbc into parse-community:master Jul 30, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants