Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apple signin authAdapter #5891

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Conversation

SebC99
Copy link
Contributor

@SebC99 SebC99 commented Aug 7, 2019

Fix #5890

We use the apple user identifier instead of the JWT token as the id

{
  "apple": {
    "id": "user",
    "token": "the identity token for the user"
  }
}

@dplewis
Copy link
Member

dplewis commented Aug 7, 2019

@SebC99 Can you look into the failing tests?

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #5891 into master will decrease coverage by 0.19%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5891     +/-   ##
=========================================
- Coverage   93.71%   93.52%   -0.2%     
=========================================
  Files         153      153             
  Lines       10727    10729      +2     
=========================================
- Hits        10053    10034     -19     
- Misses        674      695     +21
Impacted Files Coverage Δ
src/Adapters/Auth/apple.js 38.7% <50%> (-50.95%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.21% <0%> (-0.71%) ⬇️
src/RestWrite.js 93.56% <0%> (-0.17%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.59% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9462b...d84fcc7. Read the comment docs.

@SebC99
Copy link
Contributor Author

SebC99 commented Aug 7, 2019

@dplewis sorry I forgot the spec
It's done

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would you like to handle the documentation?

@dplewis dplewis merged commit b246bad into parse-community:master Aug 7, 2019
@SebC99
Copy link
Contributor Author

SebC99 commented Aug 8, 2019

I've submitted a PR to the docs repo, feel free to amend it of course!

UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Fix apple signin authAdapter to use the user id instead of the user token

* Update spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple sign-in mix between id and token
2 participants