Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongodb to the latest version 🚀 #5914

Merged
6 commits merged into from
Aug 14, 2019
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Aug 13, 2019

The dependency mongodb was updated from 3.2.7 to 3.3.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: daprahamian
License: Apache-2.0

Find out more about this release.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@ghost ghost added the Merge On Green label Aug 13, 2019
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #5914 into master will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5914      +/-   ##
==========================================
+ Coverage   93.71%   93.73%   +0.02%     
==========================================
  Files         153      153              
  Lines       10769    10773       +4     
==========================================
+ Hits        10092    10098       +6     
+ Misses        677      675       -2
Impacted Files Coverage Δ
src/ParseServer.js 97.46% <100%> (+0.04%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.94% <66.66%> (+0.01%) ⬆️
src/RestWrite.js 93.72% <0%> (+0.16%) ⬆️
src/Routers/PushRouter.js 96.55% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6760ceb...398119e. Read the comment docs.

ghost
ghost previously approved these changes Aug 13, 2019
@davimacedo
Copy link
Member

@dplewis since I've made a couple of changes, I think it would be good you take a look before merging.

@ghost ghost added the Merge On Green label Aug 13, 2019
@davimacedo davimacedo dismissed ghost ’s stale review August 13, 2019 22:25

because I want a human reviewing this PR

@dplewis
Copy link
Member

dplewis commented Aug 13, 2019

I’m reviewing it now.

@dplewis
Copy link
Member

dplewis commented Aug 13, 2019

LGTM! Can you check travis?

@davimacedo
Copy link
Member

It will probably pass now. See how beautiful the new topology implementation is (without any disclaimer in the docs):
https://github.com/mongodb-js/mongodb-core/blob/37ebcb959fb17b2d1d6224edb341bfe4006f190f/lib/sdam/topology.js#L591

I spent 3h on this :(

@dplewis
Copy link
Member

dplewis commented Aug 14, 2019

@davimacedo I'm sorry for your loss. I wouldn't have found that out.

@ghost ghost merged commit 4c1be61 into master Aug 14, 2019
@greenkeeper greenkeeper bot deleted the greenkeeper/mongodb-3.3.0 branch August 14, 2019 01:26
@davimacedo
Copy link
Member

It seems that the automation did not wait for your review. If you want me to change something, just let me know and I can send a new PR.

@dplewis
Copy link
Member

dplewis commented Aug 14, 2019

It should be fine, I learned a little bit about topology.

@davimacedo
Copy link
Member

As I did :)

UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* fix(package): update mongodb to version 3.3.0

* chore(package): update lockfile package-lock.json

* Fix tests

* Fix GraphQL tests for read preference

* Fix mongo adapter deprecation notice

* Fix the way the connections are checked, return promise when shutting down mongo
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants