-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mongodb to the latest version 🚀 #5914
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5914 +/- ##
==========================================
+ Coverage 93.71% 93.73% +0.02%
==========================================
Files 153 153
Lines 10769 10773 +4
==========================================
+ Hits 10092 10098 +6
+ Misses 677 675 -2
Continue to review full report at Codecov.
|
@dplewis since I've made a couple of changes, I think it would be good you take a look before merging. |
because I want a human reviewing this PR
I’m reviewing it now. |
LGTM! Can you check travis? |
It will probably pass now. See how beautiful the new topology implementation is (without any disclaimer in the docs): I spent 3h on this :( |
@davimacedo I'm sorry for your loss. I wouldn't have found that out. |
It seems that the automation did not wait for your review. If you want me to change something, just let me know and I can send a new PR. |
It should be fine, I learned a little bit about topology. |
As I did :) |
* fix(package): update mongodb to version 3.3.0 * chore(package): update lockfile package-lock.json * Fix tests * Fix GraphQL tests for read preference * Fix mongo adapter deprecation notice * Fix the way the connections are checked, return promise when shutting down mongo
The dependency mongodb was updated from
3.2.7
to3.3.0
.This version is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
Publisher: daprahamian
License: Apache-2.0
Find out more about this release.
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴