-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Undefined dot notation in matchKeyInQuery #5917
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5917 +/- ##
==========================================
- Coverage 93.73% 93.67% -0.07%
==========================================
Files 153 153
Lines 10773 10777 +4
==========================================
- Hits 10098 10095 -3
- Misses 675 682 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! LGTM!
* Fix: Undefined dot notation in matchKeyInQuery * fix test * fix postgres test * improve tests * FINAL test
Fixes: #5030, #4740
Fixes an uncaught error occurs if the first part of the dot notation is undefined aka key in json didn't exist.
Thanks to @JacobJT for doing the heavy lifting.