Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Lint no-prototype-builtins #5920

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Fix: Lint no-prototype-builtins #5920

merged 2 commits into from
Aug 14, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 14, 2019

@codecov
Copy link

codecov bot commented Aug 14, 2019 •
edited
Loading

Codecov Report

Merging #5920 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5920      +/-   ##
==========================================
- Coverage   93.69%   93.68%   -0.01%     
==========================================
  Files         153      153              
  Lines       10777    10801      +24     
==========================================
+ Hits        10097    10119      +22     
- Misses        680      682       +2
Impacted Files Coverage Δ
src/Adapters/Auth/index.js 92.98% <ø> (ø) ⬆️
src/Adapters/Storage/Mongo/MongoTransform.js 88.31% <ø> (ø) ⬆️
src/Routers/AggregateRouter.js 100% <100%> (ø) ⬆️
src/LiveQuery/ParseLiveQueryServer.js 90.06% <100%> (ø) ⬆️
src/cloud-code/Parse.Cloud.js 97.67% <100%> (ø) ⬆️
src/cli/utils/commander.js 100% <100%> (ø) ⬆️
src/Routers/UsersRouter.js 94.19% <100%> (ø) ⬆️
src/LiveQuery/QueryTools.js 94.04% <100%> (ø) ⬆️
src/ParseServer.js 97.46% <100%> (ø) ⬆️
src/defaults.js 95% <100%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ac88e...a98dca3. Read the comment docs.

@dplewis dplewis requested review from davimacedo and acinader August 14, 2019 18:20
@davimacedo
Copy link
Member

The recommendation in the reference is actually Object.prototype.hasOwnProperty.call and not Object.hasOwnProperty.call. I am not sure about the difference between the two options though. What do you think?

@dplewis
Copy link
Member Author

dplewis commented Aug 14, 2019 •
edited
Loading

@davimacedo I agree with you, most of the documentation I looked up uses Object.prototype. I made the changes

davimacedo
davimacedo approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit cf6e79e into master Aug 14, 2019
@dplewis dplewis deleted the no-prototype-builtins branch August 15, 2019 03:01
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@dplewis @davimacedo
Fix: Lint no-prototype-builtins (parse-community#5920)
ead8dae 
* Fix: Lint no-prototype-builtins

Closes: parse-community#5842

Reference: https://eslint.org/docs/rules/no-prototype-builtins

* replace Object.hasOwnProperty.call
This was referenced Mar 17, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

@acinader acinader Awaiting requested review from acinader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow use of Object.prototypes builtins directly (no-prototype-builtins)
2 participants
@dplewis @davimacedo