-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added array support for pointer-permissions #5921
Added array support for pointer-permissions #5921
Conversation
The build for PostgreSQL currently fails since it doesn't support the
The advantage of 2. is that it should work on both dbs. The advantage of 1. is that it's coherent with the one-user pointer-permissions which uses columns of the type Pointer<_User>. I would go with number 2. Or is 1 the way to go? |
@Dobbias Thank for starting on this PR. I don't know much about permissions but I can look into postgres for you. $all could be transformed to |
Codecov Report
@@ Coverage Diff @@
## master #5921 +/- ##
==========================================
- Coverage 93.72% 93.69% -0.03%
==========================================
Files 153 156 +3
Lines 10801 10866 +65
==========================================
+ Hits 10123 10181 +58
- Misses 678 685 +7
Continue to review full report at Codecov.
|
@Dobbias That code was already there so the Postgres fix was easy. |
* added array support for pointer permissions * added tests for array support for pointer permissions * Postgres fix * simplify PG, no idea why this works
This adds the ability to provide array columns to 'readUserFields' or 'writeUserFields'.
All Pointer<_User> in the array stored in the object field are granted the read and/or write permission.
This extends the pointer permissions without affecting the ability of using single Pointer<_User> columns.
This functionality is also needed for future additions to the protected fields as discussed in pull request #5887