Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL: Fix undefined Array #5926

Merged
merged 4 commits into from
Aug 16, 2019
Merged

GraphQL: Fix undefined Array #5926

merged 4 commits into from
Aug 16, 2019

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Aug 15, 2019 •
edited
Loading

@codecov
Copy link

codecov bot commented Aug 15, 2019 •
edited
Loading

Codecov Report

Merging #5926 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5926      +/-   ##
==========================================
+ Coverage   93.67%   93.72%   +0.04%     
==========================================
  Files         156      156              
  Lines       10862    10863       +1     
==========================================
+ Hits        10175    10181       +6     
+ Misses        687      682       -5
Impacted Files Coverage Δ
src/GraphQL/loaders/parseClassTypes.js 85.33% <100%> (+0.06%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.67% <0%> (+0.08%) ⬆️
src/RestWrite.js 93.89% <0%> (+0.16%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.94% <0%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8da12...3160f7e. Read the comment docs.

@Moumouls Moumouls marked this pull request as ready for review August 15, 2019 22:53
davimacedo
davimacedo approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit cea1988 into parse-community:master Aug 16, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@Moumouls @davimacedo
GraphQL: Fix undefined Array (parse-community#5926)
40373ae 
* Add Spec

* Fix Undefined Array

* Nullability policy
This was referenced Mar 17, 2024
Closed
Closed
Closed
Closed
Merged
@Arul- Arul- mentioned this pull request Oct 9, 2024
Open
@kiarza2543 kiarza2543 mentioned this pull request Oct 10, 2024
Open
@pradyum07 pradyum07 mentioned this pull request Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Moumouls @davimacedo