Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Live Query Monitoring #5927

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Improve Live Query Monitoring #5927

merged 2 commits into from
Aug 16, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 16, 2019

Adds support for installationId.

Fixes inconsistency with Wiki where connect should set session token to the client. This will have lower priority than a subscribe with sessionToken when verifying ACL.

Let me know if any other fields should be added.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #5927 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5927      +/-   ##
==========================================
+ Coverage   93.67%   93.67%   +<.01%     
==========================================
  Files         156      156              
  Lines       10862    10865       +3     
==========================================
+ Hits        10175    10178       +3     
  Misses        687      687
Impacted Files Coverage Δ
src/LiveQuery/Client.js 100% <100%> (ø) ⬆️
src/LiveQuery/ParseLiveQueryServer.js 90.12% <100%> (+0.06%) ⬆️
src/RestWrite.js 93.56% <0%> (-0.17%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.67% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8da12...7607916. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good to me! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants