-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nested operations from GraphQL API #5931
Remove nested operations from GraphQL API #5931
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5931 +/- ##
==========================================
- Coverage 93.73% 93.68% -0.05%
==========================================
Files 156 156
Lines 10870 10838 -32
==========================================
- Hits 10189 10154 -35
- Misses 681 684 +3
Continue to review full report at Codecov.
|
I think we should also later improve the callCloudCode to receive from a FunctionEnum, instead of a String. I will add the task in the project. |
@davimacedo I think above all that we will have to think in the long term about how to integrate cloud function more cleanly (enum is a first step) into the graphql server, or even recommend using custom resolvers instead. |
In my opinion, I think that the custom resolvers solve the problem of cloud code functions integration to the GraphQL API. The |
* Remove nested operations * Improve error log * Fix bug schema to load * Fix ParseGraphQLSchema tests * Fix tests * Fix failing tests * Rename call to callCloudCode
No description provided.