-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL schema operations #5993
GraphQL schema operations #5993
Conversation
Close #5925 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to be able to manipulate the schema from GraphQL 🎉
Some general comments:
objectsQueries
and objectsMutations
are not loaders anymore, so I believe we could move them to another dir.
About classSchemaMutations
, wouldn't it be parseSchemaMutations
or just schemaMutations
? Same applies to classSchemaQueries
.
Codecov Report
@@ Coverage Diff @@
## master #5993 +/- ##
==========================================
- Coverage 93.73% 93.73% -0.01%
==========================================
Files 156 163 +7
Lines 10939 11080 +141
==========================================
+ Hits 10254 10386 +132
- Misses 685 694 +9
Continue to review full report at Codecov.
|
The spec and the implementation seems good to me. So great job, we are currently moving to a full app backend fully manageable via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Moumouls yes. That's the idea. Later we need to include indexes, CLP, defaultValue and required information. I just added a task in the project. |
* Remove nested operations * Improve error log * Fix bug schema to load * Fix ParseGraphQLSchema tests * Fix tests * Fix failing tests * First verstion not complete of create class mutation * Fix bug caused by circular dependency * Renaming files * Schema types should be loaded before parse classes * Fix tests * Create class mutation boilerplate * Improve CreateClassSchemaInput fields names * Remove fields * Pointer and relation fields * Improve pointer default type * Class type * Create class mutation resolver * Schema field transformers * Class types transformations * First test * Numbers test * Boolean tests * Date test * Fix some get tests * Test for created at and updated at * File tests * Test for objects * Renaming reducerFabric to reducerGenerator * Changing get tests for file and object * Object composed queries test * Array test * Null field test * Bytes test * Geo Point test * Polygons tests * Remove create generic mutation * Fix tests * Create class test - isRequired and defaultValue will be added back later * Enforce master key * Fix tests * Duplicated field test * updateClass mutation * Remove update generic mutation tests * Remove update generic mutation * deleteClass mutation * Remove delete generic mutation tests * Remove delete generic mutation * class query * Classes query * Remove get generic query from tests * Remove remaining generic operations and fix tests * Fix last test * Try to fix redis tests * Fix postgres tests * Update objectsMutations and objectsQueries files locations * Rename classSchema files to schema files * Rename ClassObject to ParseObject * Fix names and paths * Still some wrong names
Includes:
Removes:
Fix tests that depend on generic operations.