fix(RestWrite): make method async as expected in usage #6025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `createSessionToken` in RestWrite.js is assumed to always return a promise (see Line 961 in `handleFollowUp`) - this was throwing an error `cannot read 'then' of undefined`. This simply one word change fixes that error.
Codecov Report
@@ Coverage Diff @@
## master #6025 +/- ##
==========================================
- Coverage 93.79% 93.79% -0.01%
==========================================
Files 164 164
Lines 11096 11096
==========================================
- Hits 10408 10407 -1
- Misses 688 689 +1
Continue to review full report at Codecov.
|
|
@omairvaiyani it seems we should also declare async the (we have some weird cases of instrumentations where this method is not recognized as a promise) |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
…ty#6025) The method `createSessionToken` in RestWrite.js is assumed to always return a promise (see Line 961 in `handleFollowUp`) - this was throwing an error `cannot read 'then' of undefined`. This simply one word change fixes that error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
createSessionTokenin RestWrite.js is assumed to always return a promise (see Line 961 inhandleFollowUp) - this was throwing an errorcannot read 'then' of undefined. This simple one word change fixes that error.